Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trunc #55763

Closed
wants to merge 2 commits into from
Closed

Trunc #55763

wants to merge 2 commits into from

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

#53672, temporarily use patch from https://lore.kernel.org/lkml/20190214012754.GA17326@beast/T/#u

Need to bring back 4.14.99

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @eadwu @grahamc @dtzWill @laaas

@NeQuissimus NeQuissimus mentioned this pull request Feb 14, 2019
Closed
@grahamc
Copy link
Member

grahamc commented Feb 14, 2019

I'm calling in some C reviewers to take a look.

@grahamc
Copy link
Member

grahamc commented Feb 14, 2019

^ non-blocking

@grahamc
Copy link
Member

grahamc commented Feb 14, 2019

Note: more kernel bumps were reverted in 18.09.

@dtzWill dtzWill mentioned this pull request Feb 14, 2019
Closed
10 tasks
@grahamc
Copy link
Member

grahamc commented Feb 14, 2019

This patch has been reviewed by Oleg on LKML and they found off-by-one errors.

grahamc
grahamc requested changes Feb 14, 2019
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamc
Copy link
Member

grahamc commented Feb 14, 2019

Linus suggests a simple revert https://lore.kernel.org/lkml/20190214164331.GA33450@beast/T/#m7b4d9db7b8abc0c2752805818d1ac4a19acb5299

@NeQuissimus
Copy link
Member Author

Let's do that then. Can anybody take that on? I am just shutting down my computer... :)

@NeQuissimus NeQuissimus deleted the trunc branch February 14, 2019 19:03
@eadwu eadwu mentioned this pull request Feb 14, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc requested changes

@samueldr samueldr Awaiting requested review from samueldr

@vcunat vcunat Awaiting requested review from vcunat

@aszlig aszlig Awaiting requested review from aszlig

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeQuissimus @grahamc @GrahamcOfBorg