Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3: stop using aliases #55735

Merged
merged 1 commit into from Feb 14, 2019
Merged

gnome3: stop using aliases #55735

merged 1 commit into from Feb 14, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar force-pushed the gnome-no-alias branch 7 times, most recently from ad40838 to 0d77024 Compare February 14, 2019 00:55
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: pantheon The Pantheon desktop environment label Feb 14, 2019
@jtojnar jtojnar merged commit 4a0c2ac into NixOS:staging Feb 14, 2019
@jtojnar jtojnar deleted the gnome-no-alias branch February 14, 2019 06:02
jtojnar added a commit to jtojnar/cabal2nix that referenced this pull request Mar 2, 2019
@jtojnar
resolveInNixpkgs: stop using GNOME aliases
6b9bca8 
They were removed in NixOS/nixpkgs#55735
@jtojnar jtojnar mentioned this pull request Mar 2, 2019
Merged
worldofpeace pushed a commit that referenced this pull request Mar 24, 2019
@worldofpeace
gnome3.gtk -> gtk3
2be90cc 
fix evaluation when config.allowAliases == false

(regression after #55735)
Profpatsch pushed a commit to Profpatsch/cabal2nix that referenced this pull request Mar 7, 2022
@jtojnar @Profpatsch
resolveInNixpkgs: stop using GNOME aliases
69b0ff6 
They were removed in NixOS/nixpkgs#55735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@infinisil infinisil Awaiting requested review from infinisil

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg