Change: Use selected group as parent when creating a new group. #7224
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsmh
approved these changes
Feb 14, 2019
|
Great idea. I also expected to inherit liveries instead of copying them. |
|
Inheritance is set by the in_use flag, in the case of inheritance colour1/colour2 are set to the parent. This is because when using 2cc mode, the two colours can actually inherit from different parent groups independently, but GetEngineLivery returns a Livery struct, not two colours. When changing a parent livery, PropagateChildLivery() applies that change to all the group's children recursively. Turns out there's some left over code in GetEngineLivery that traverses parents when it's not actually necessary. Oops. |
PeterN
added
the
wip
|
Okay, I think it should check the group ID exists and return an error if not, instead of silently creating a top-level group. Going to fix it :-) EDIT: Other functions also do it this way, so for consistency I'll leave this as is and then change them all together, possibly. |
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this pull request
Feb 15, 2019
PeterN
added a commit
that referenced
this pull request
Feb 15, 2019
J0anJosep
added a commit
to J0anJosep/OpenTTD
that referenced
this pull request
Feb 18, 2019
J0anJosep
added a commit
to J0anJosep/OpenTTD
that referenced
this pull request
Feb 18, 2019
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Mar 11, 2019
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Mar 11, 2019
stormcone
added a commit
to stormcone/OpenTTD
that referenced
this pull request
May 10, 2019
… correctly. When drag and drop a vehicle into an empty slot in the vehicle group window it tries to create the new group as the subgroup of the first group (GroupID = 0). This is failing if the dragged vehicle's type is different than the first group's vehicle type.
stormcone
added a commit
to stormcone/OpenTTD
that referenced
this pull request
May 10, 2019
…correctly. When drag and drop a vehicle into an empty slot in the vehicle group window it tries to create the new group as the subgroup of the first group (GroupID = 0). This is failing if the dragged vehicle's type is different than the first group's vehicle type.
nielsmh
pushed a commit
that referenced
this pull request
May 10, 2019
When drag and drop a vehicle into an empty slot in the vehicle group window it tries to create the new group as the subgroup of the first group (GroupID = 0). This is failing if the dragged vehicle's type is different than the first group's vehicle type.
michicc
pushed a commit
to michicc/OpenTTD
that referenced
this pull request
Jun 30, 2019
…correctly. When drag and drop a vehicle into an empty slot in the vehicle group window it tries to create the new group as the subgroup of the first group (GroupID = 0). This is failing if the dragged vehicle's type is different than the first group's vehicle type.
michicc
pushed a commit
that referenced
this pull request
Jul 7, 2019
When drag and drop a vehicle into an empty slot in the vehicle group window it tries to create the new group as the subgroup of the first group (GroupID = 0). This is failing if the dragged vehicle's type is different than the first group's vehicle type.
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
…correctly. When drag and drop a vehicle into an empty slot in the vehicle group window it tries to create the new group as the subgroup of the first group (GroupID = 0). This is failing if the dragged vehicle's type is different than the first group's vehicle type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.