I can see that @Ma27 worked too on the module. How can I merge our work without break the master ? :)

You should go back to your first commit (4c4f068c1496ba50d516402aca27486fde43dd2c) and then run something like git rebase master.

I didn't go through the changes (yet) so I don't know if there will be any conflicts. If you need assistance with resolving those, feelf ree to ping me.

PS : I'm searching how to use a passwordFile option also and don't stock password on store.

You could read it with file_get_contents:

{
  environment.etc."roundcube/config.inc.php".text = ''
    <?php
    $config['smtp_pass'] = file_get_contents('${cfg.smtpPasswordFile}');
  '';
}

Please keep in mind that file_get_contents returns false and only yields a warning and this needs some better error handling.

Admittedly I'm not sure anymore if we actually want to merge this. There's the NixOS RFC 42 which proposes to simplify the complexity of modules by using a simple config attribute rather than multiple options and add several library helpers to render the config attr set in any given configuration language (or PHP in this case).

OK. So I can close this and do another pull request for password stuff

I'd wait for now. I'd recommend to use extraConfig for this kind of stuff for now and wait how the RFC develops :)

Ah and I've just seen that you force-pushed after my comment. IIRC I didn't get a notification for this (not sure how GitHub handles this), so feel free to ping the reviewer the next time (or at least leave a comment under the review when fixing stuff).

Not really relevant now I think