Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: allow for interpreter to be truncated #55793

Merged
merged 2 commits into from Feb 15, 2019
Merged

linux: allow for interpreter to be truncated #55793

merged 2 commits into from Feb 15, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Feb 14, 2019 •
edited

Motivation for this change

Now just give me a few hours to compile using this specific patch taken from the git repository instead of my own.

Based off #55763, though I don't think linux_testing_bcachefs needs to be patched, as it's still based upon 4.20.0.

Resolves #53672.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @NeQuissimus @grahamc @dtzWill

@eadwu
Copy link
Member Author

eadwu commented Feb 15, 2019

4.20.8 boots and nixos-rebuild switch runs fine for me.

@NeQuissimus NeQuissimus merged commit f0b8a11 into NixOS:master Feb 15, 2019
@grahamc
Copy link
Member

grahamc commented Feb 15, 2019

@NeQuissimus would you like to backport to 18.09 as well?

@NeQuissimus
Copy link
Member

On it

@NeQuissimus
Copy link
Member

9c78f68 c4b10f8

@NeQuissimus
Copy link
Member

hmm, there are old kernels in stable, I have to try them out

@grahamc
Copy link
Member

grahamc commented Feb 15, 2019

The kernel bumps were reverted on stable

@NeQuissimus
Copy link
Member

I think I have it all figured out now

@eadwu eadwu deleted the linux/interpreter-trunc branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @grahamc @NeQuissimus @GrahamcOfBorg