New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow duosec to be used in nixos as a pam module. #55792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdier
force-pushed
the
fix/pam-update
branch
from
February 14, 2019 23:18
0b36e98
to
8008c74
Compare
infinisil
reviewed
Feb 18, 2019
sdier
force-pushed
the
fix/pam-update
branch
from
February 24, 2019 14:01
8008c74
to
8ae9ed0
Compare
infinisil
reviewed
Feb 24, 2019
sdier
force-pushed
the
fix/pam-update
branch
2 times, most recently
from
February 24, 2019 15:34
d7ac2fc
to
a6d369c
Compare
infinisil
approved these changes
Feb 24, 2019
flokli
approved these changes
Feb 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you add an item inside sec-release-19.03-new-services
in nixos/doc/manual/release-notes/rl-1903.xml
?
sdier
force-pushed
the
fix/pam-update
branch
from
February 24, 2019 22:49
a6d369c
to
a11ad16
Compare
Looking good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of no idea dog here -- I'm not entirely sure I understand the testing requirements yet for a nixos-only change. Please let me know if I misunderstood what to do.
Also, while I updated documentation in the nixos module, if additional documentation is needed please let me know where it should go.
Thanks!
Motivation for this change
Make it possible to configure duosec with pam for ssh. It allows folks to use ssh keys without a 2FA prompt, but passwords with a 2FA prompt.
Things done
I tested this by installing settings on a machine with ssh with this configuration:
services.openssh.enable = true;
security.duosec.pam.enable = true;
security.duosec.autopush = true;
security.pam.services.sshd.duoSecurity.enable = true;
I did manual tests:
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)