Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rippled: 0.30.0-rc1 -> 1.2.0 #55772

Merged
merged 1 commit into from Feb 15, 2019
Merged

rippled: 0.30.0-rc1 -> 1.2.0 #55772

merged 1 commit into from Feb 15, 2019

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Fixing and updating of rippled

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@offlinehacker offlinehacker mentioned this pull request Feb 14, 2019
Merged
10 tasks
@offlinehacker
Copy link
Contributor Author

@GrahamcOfBorg build rippled

@offlinehacker
Copy link
Contributor Author

I'm merging this as it works fine on our k8s clusters.

@offlinehacker offlinehacker merged commit c70de6b into NixOS:master Feb 15, 2019
@offlinehacker offlinehacker deleted the pkgs/rippled/1.2.0 branch February 15, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejc matejc Awaiting requested review from matejc

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@offlinehacker @GrahamcOfBorg