Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-ost: 1.0.36 -> 1.0.47 #55726

Merged
merged 1 commit into from Feb 17, 2019
Merged

gh-ost: 1.0.36 -> 1.0.47 #55726

merged 1 commit into from Feb 17, 2019

Conversation

cransom
Copy link
Contributor

@cransom cransom commented Feb 13, 2019

Also fixes a weirdness with the derivation where to use it, you needed
to specify gh-ost.gh-ost. There's nothing special about the extra
output.

Motivation for this change

Update version, fix weird install step.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

gh-ost: 1.0.36 -> 1.0.47
81a2881 
Also fixes a weirdness with the derivation where to use it, you needed
to specify `gh-ost.gh-ost`. There's nothing special about the extra
output.
@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

@GrahamcOfBorg build gh-ost

@ryantm ryantm merged commit 92bc2f7 into NixOS:master Feb 17, 2019
@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

Thanks; please consider adding yourself as a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cransom @ryantm @GrahamcOfBorg