Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.architecture: fix sandbox build #55784

Merged
merged 1 commit into from Feb 16, 2019
Merged

darwin.architecture: fix sandbox build #55784

merged 1 commit into from Feb 16, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin-stdenv labels Feb 14, 2019
@copumpkin
Copy link
Member

Nice! How did we miss this one before? 😮

@copumpkin copumpkin merged commit cc8545f into NixOS:master Feb 16, 2019
@LnL7
Copy link
Member Author

LnL7 commented Feb 16, 2019

Sandboxing has been disabled for a while now. I've been spending some time on getting it back into shape with a slightly more relaxed approach that avoids the current problems with frameworks and hydra.

extra-sandbox-paths = /System/Library/Frameworks /System/Library/PrivateFrameworks /usr/lib

@LnL7 LnL7 deleted the darwin-architecture branch February 16, 2019 20:00
@vcunat
Copy link
Member

vcunat commented Feb 17, 2019

A mass darwin rebuild directly to master? That's intentional, right? Note that Hydra is quite bottle-necked on darwin these weeks.

vcunat added a commit that referenced this pull request Feb 17, 2019
@vcunat
Merge branch 'master' into staging-next
f7f1a2f 
A mass darwin rebuild from master (#55784).
@LnL7
Copy link
Member Author

LnL7 commented Feb 17, 2019

Oh it was not, thought I changed it to staging.

@vcunat
Copy link
Member

vcunat commented Feb 17, 2019

@LnL7: I assume it's unlikely to cause much breakage, so let me revert it on master and leave on staging-next. There's a mass darwin rebuild to do on staging-next anyway, due to unzip security fix.

@LnL7
Copy link
Member Author

LnL7 commented Feb 17, 2019

I just did that.

@copumpkin
Copy link
Member

copumpkin commented Feb 17, 2019 •
edited

Whoops, sorry, missed the master/staging thing!

@vcunat
Copy link
Member

vcunat commented Feb 18, 2019 •
edited

Perhaps Borg might post a warning comment to the PR in some cases, but I'm not sure...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LnL7 @copumpkin @vcunat @GrahamcOfBorg