Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multimc: unstable-2018-06-04 -> 0.6.4 #55701

Merged
merged 1 commit into from Mar 2, 2019
Merged

multimc: unstable-2018-06-04 -> 0.6.4 #55701

merged 1 commit into from Mar 2, 2019

Conversation

leo60228
Copy link
Member

Motivation for this change

0.6.4 is the latest beta version of MultiMC. We are currently using an unstable commit, so I consider this an improvement. This closes #55699 via the second option listed there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" N/A
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@leo60228
Copy link
Member Author

Just realized that I forgot to update the version field. Oops.

@worldofpeace
Copy link
Contributor

So this is a stable release MultiMC/Launcher#2536 (comment)

This should be fine to merge.

@worldofpeace
Copy link
Contributor

Hmm the directory structure does not look right

❯ tree ./result
./result
├── bin
│   ├── jars
│   │   ├── JavaCheck.jar
│   │   └── NewLaunch.jar
│   ├── libMultiMC_gui.so
│   ├── libMultiMC_iconfix.so
│   ├── libMultiMC_logic.so
│   ├── libMultiMC_nbt++.so
│   ├── libMultiMC_quazip.so
│   ├── libMultiMC_rainbow.so
│   ├── libMultiMC_unpack200.so
│   ├── multimc -> /nix/store/11x78ynj5cbi0plk8ng9pz2rhvqk3k34-multimc-0.6.4/bin/MultiMC
│   └── MultiMC
├── MultiMC
├── nix-support
│   └── propagated-user-env-packages
└── share
    ├── applications
    │   └── multimc.desktop
    └── pixmaps
        └── multimc.svg

6 directories, 15 files

@leo60228
Copy link
Member Author

@worldofpeace This is what it was on old versions, too. Not sure how to fix it.

@leo60228
Copy link
Member Author 

[leo60228@leotop2:~/Dotfiles]$ nix run nixpkgs.tree -c tree $(nix-build --no-out-link '<nixpkgs>' -A multimc)
/nix/store/iymm3pdcf3622q2kwmsdj9r19n3l7v0r-multimc-unstable-2018-06-04
├── bin
│   ├── jars
│   │   ├── JavaCheck.jar
│   │   └── NewLaunch.jar
│   ├── libMultiMC_gui.so
│   ├── libMultiMC_iconfix.so
│   ├── libMultiMC_logic.so
│   ├── libMultiMC_nbt++.so
│   ├── libMultiMC_quazip.so
│   ├── libMultiMC_rainbow.so
│   ├── libMultiMC_unpack200.so
│   ├── multimc -> /nix/store/iymm3pdcf3622q2kwmsdj9r19n3l7v0r-multimc-unstable-2018-06-04/bin/MultiMC
│   └── MultiMC
├── MultiMC
├── nix-support
│   └── propagated-user-env-packages
└── share
    ├── applications
    │   └── multimc.desktop
    └── pixmaps
        └── multimc.svg

6 directories, 15 files

@srhb srhb merged commit a76ffce into NixOS:master Mar 2, 2019
@worldofpeace worldofpeace mentioned this pull request Mar 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverca22 cleverca22 cleverca22 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decide on what version of MultiMC to use
5 participants
@leo60228 @worldofpeace @cleverca22 @srhb @GrahamcOfBorg