haskell.packages.ghc822/844: Fix configuration and build of GHC822/844 #55703

artempyanykh · 2019-02-13T13:15:14Z

Motivation for this change

nix-env -qaP -A haskell.packages.ghc8xx for GHC822 and 844 fails with:

nix called without required argument 'ghc-heap'

Adding ghc-heap = null to respective configuration files leads to further failures due to missing attributes (specific version of haskell packages).
Furthermore, when all configuration problems are resolved the ghc build itself fails due to sphinx.

I'm new to nix, so if there's a way to avoid copy-paste or version-pinning, please let me know!

Things done

pkgs/top-level/haskell-packages.nix

peti

Please don't edit pkgs/development/haskell-modules/hackage-packages.nix. Please see the comment at the very top.

8.4.4 requires < 1.8 sphinx, otherwise build fails on haddock with: Extension error: The 'ghc-flag' directive is already registered to domain std

artempyanykh · 2019-02-13T15:22:04Z

@peti thanks, I see from @dotlambda 's suggestion how to change version/sha256 without creating new attributes in hackage-packages. I'll make the change.

Co-Authored-By: artempyanykh <artem.pyanykh@gmail.com>

artempyanykh · 2019-02-13T20:35:04Z

@peti looks like after all I haven't completely figured it out. A couple things:

Unfortunately, I couldn't figure out how to call overrideAttrs within configuration-ghc-xx, so I just moved relevant definitions to respective configuration files out of hackage-packages. Even then, it's not particularly clear why we need some special version-pinned packages in a specific ghc configuration (for instance yaml_0_11_.. is no longer a thing in 844 config) or if overrideAttrs is any clearer than just dropping a full derivation.
Cabal_1_24_2_0 in 822 compiles with one more patch for dependency constraint.
hackage-db-2_0_1 fails during compilation --- for some reason aeson doesn't have a dependency on contravarian in hackage-packages which it should have.
stack and hpack_0_31_1 in 844 (after removing non-working yaml dep) started to compile... and still are compiling after several hours. Will update later.

UPD: hpack_0_31_1 builds fine, but stack fails due to build failure of one of its dependencies:

These modules are needed for compilation but not listed in your .cabal file's other-modules:
Data.Algorithm.Diff
Data.Algorithm.DiffOutput

…ation-ghc

peti · 2019-02-20T13:07:42Z

pkgs/development/haskell-modules/configuration-ghc-8.2.x.nix

-  Cabal_1_24_2_0 = overrideCabal super.Cabal_1_24_2_0 (drv: {
-    prePatch = "sed -i -e 's/process.*< 1.5,/process,/g' Cabal.cabal";
-  });
+  Cabal_1_24_2_0 = self.callPackage


What is the point of that change? I don't see what this is supposed to accomplish?

@peti super.Cabal_1_24_2_0 is not a thing anymore (I guess it was in hackage_packages sometime ago, but not now). Without this change nix-env -qaP haskell.packages.ghc822 fails.

I'd simply remove this derivation, but

the comment above says "# Make sure we can still build Cabal 1.x." 🤷‍♂️

removing this derivation is a breaking change if someone depends on it and\or cares.

So, I fixed this super.Cabal_1_24_2_0 issue and adjusted prePatch section so that Cabal successfully builds.

Does this answer your question?

P.S. If no one cares about pkgname_{version} derivations in ghc_8.x configurations, I can just remove them.

Just drop the override. It's been broken for a long time and doubt anyone cares about Cabal 1.x any more.

peti · 2019-02-21T07:41:46Z

pkgs/development/haskell-modules/configuration-ghc-8.2.x.nix

-  Cabal_1_24_2_0 = overrideCabal super.Cabal_1_24_2_0 (drv: {
-    prePatch = "sed -i -e 's/process.*< 1.5,/process,/g' Cabal.cabal";
-  });
+  Cabal_1_24_2_0 = self.callPackage


Just drop the override. It's been broken for a long time and doubt anyone cares about Cabal 1.x any more.

peti · 2019-02-21T07:42:29Z

pkgs/development/haskell-modules/configuration-ghc-8.2.x.nix

@@ -89,7 +116,24 @@ self: super: {
  cabal2nix = super.cabal2nix.overrideScope (self: super: { Cabal = self.Cabal_2_2_0_1; });
  cabal2spec = super.cabal2spec.overrideScope (self: super: { Cabal = self.Cabal_2_2_0_1; });
  distribution-nixpkgs = super.distribution-nixpkgs.overrideScope (self: super: { Cabal = self.Cabal_2_2_0_1; });
-  hackage-db_2_0_1 = super.hackage-db_2_0_1.overrideScope (self: super: { Cabal = self.Cabal_2_2_0_1; });
+  hackage-db_2_0_1 = (self.callPackage


Why did you add this Nix build into the overrides file?

IDK what's the policy regarding keeping old version pinned derivations (and whether it's important to preserve them).

I assume that according to your comment about Cabal_1_x, no one cares about these, so I just removed them. Let me know if something other is desired.

peti · 2019-02-21T07:43:05Z

pkgs/development/haskell-modules/configuration-ghc-8.4.x.nix

-  hpack_0_31_1 = super.hpack_0_31_1.override {
-    yaml = self.yaml_0_11_0_0;
-  };
+  hpack_0_31_1 = self.callPackage


Same here. Why did you add that build expression into the overrides file?

peti · 2019-02-21T07:43:53Z

pkgs/top-level/haskell-packages.nix

@@ -55,7 +55,13 @@ in {
    };
    ghc844 = callPackage ../development/compilers/ghc/8.4.4.nix {
      bootPkgs = packages.ghc822Binary;
-      inherit (buildPackages.python3Packages) sphinx;
+      sphinx = buildPackages.python3Packages.sphinx.overridePythonAttrs (oldAttrs: rec {


Please add a sphinx_1_7_9 attribute into python-packages.nix instead.

artempyanykh · 2019-02-21T12:29:10Z

nix-env -qaP -A haskell.packages.ghc8xx works.
ghc844 builds just fine.
sphinx_1_7_9 moved under pyhon_packages.
Old version-pinned derivations in 822/844 configurations are removed.

@peti looks good?

ghc-8.4.4 requires sphinx < 1.8, otherwise build fails on haddock with: Extension error: The 'ghc-flag' directive is already registered to domain std Also fixed evaluation errors in configurations of ghc-8.2.x and ghc-8.4.x. Closes #55703.

peti · 2019-02-27T08:26:29Z

Merged to haskell-updates as a251d91. I'll merge to master once the test builds at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates have come back successfully.

artempyanykh requested review from basvandijk, FRidh, peti and ryantm as code owners February 13, 2019 13:15

GrahamcOfBorg added 6.topic: haskell 6.topic: python labels Feb 13, 2019

dotlambda reviewed Feb 13, 2019

View reviewed changes

pkgs/top-level/haskell-packages.nix Show resolved Hide resolved

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 13, 2019

peti requested changes Feb 13, 2019

View reviewed changes

artempyanykh added 2 commits February 13, 2019 17:49

haskell.packages.ghc822/844: Fix configurations of GHC822 and GHC844

9c00229

haskell.packages.ghc844.ghc: Fix failed build due to sphinx

d783858

8.4.4 requires < 1.8 sphinx, otherwise build fails on haddock with: Extension error: The 'ghc-flag' directive is already registered to domain std

Update pkgs/top-level/haskell-packages.nix

646c09f

Co-Authored-By: artempyanykh <artem.pyanykh@gmail.com>

artempyanykh force-pushed the fix-ghc822-844 branch from 66f49ab to e159c83 Compare February 13, 2019 20:37

haskell.packages.ghc822/844: Move version-pinned packages to configur…

e159c83

…ation-ghc

peti reviewed Feb 20, 2019

View reviewed changes

peti requested changes Feb 21, 2019

View reviewed changes

GrahamcOfBorg added 2.status: merge conflict and removed 2.status: merge conflict labels Feb 21, 2019

artempyanykh added 2 commits February 21, 2019 17:58

Move sphinx 1.7.9 under python_packages, remove old haskell derivations

8ac68b6

Merge branch 'master' into fix-ghc822-844

b43dbb2

peti approved these changes Feb 27, 2019

View reviewed changes

peti closed this in f7003e5 Feb 27, 2019

artempyanykh deleted the fix-ghc822-844 branch February 28, 2019 09:05

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

haskell.packages.ghc822/844: Fix configuration and build of GHC822/844 #55703

haskell.packages.ghc822/844: Fix configuration and build of GHC822/844 #55703

artempyanykh commented Feb 13, 2019 •

edited

peti left a comment

artempyanykh commented Feb 13, 2019

artempyanykh commented Feb 13, 2019 •

edited

peti Feb 20, 2019

artempyanykh Feb 20, 2019

peti Feb 21, 2019

peti Feb 21, 2019

peti Feb 21, 2019

artempyanykh Feb 21, 2019

peti Feb 21, 2019

artempyanykh Feb 21, 2019

peti Feb 21, 2019

artempyanykh Feb 21, 2019

artempyanykh commented Feb 21, 2019 •

edited

peti commented Feb 27, 2019

haskell.packages.ghc822/844: Fix configuration and build of GHC822/844 #55703

haskell.packages.ghc822/844: Fix configuration and build of GHC822/844 #55703

Conversation

artempyanykh commented Feb 13, 2019 • edited

Motivation for this change

Things done

peti left a comment

Choose a reason for hiding this comment

artempyanykh commented Feb 13, 2019

artempyanykh commented Feb 13, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artempyanykh commented Feb 21, 2019 • edited

peti commented Feb 27, 2019

artempyanykh commented Feb 13, 2019 •

edited

artempyanykh commented Feb 13, 2019 •

edited

artempyanykh commented Feb 21, 2019 •

edited