Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick patch to bump BINPRM_BUF_SIZE from 128 to 1024 #55734

Closed
wants to merge 1 commit into from
Closed

quick patch to bump BINPRM_BUF_SIZE from 128 to 1024 #55734

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 13, 2019

Doesn't fix the problem but fixes my/our machines for now.

I'm running 4.20.8 with this presently,
other kernels "should" patch okay but I haven't checked.

And I wasn't sure if hardening wanted this or not? Dunno.

#53672 (comment)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
quick patch to bump BINPRM_BUF_SIZE from 128 to 1024
194fada 
Doesn't fix the problem but fixes my/our machines for now.

I'm running 4.20.8 with this presently,
other kernels "should" patch okay but I haven't checked.

And I wasn't sure if hardening wanted this or not? Dunno.

NixOS#53672 (comment)
@dtzWill
Copy link
Member Author

dtzWill commented Feb 13, 2019

Haha so I ran into this gem in a texlive build: https://gist.github.com/dtzWill/5d4324eb3ef9d3c7dfbb0f690768dc91

According to head -n1|/path/to/file-in-gist|wc -c it's... 30902 characters, lmao.

That's, uh, a bit intense hahaha (and quite possibly not a nixpkgs problem and just something silly I'm doing, haven't chased it down yet).

NeQuissimus
NeQuissimus approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@NeQuissimus NeQuissimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try this out on a hardened 4.20.8 tomorrow

@grahamc
Copy link
Member

grahamc commented Feb 14, 2019

FYI: https://lkml.org/lkml/2019/2/13/1437 and related emails.

@NeQuissimus
Copy link
Member

Looks like Kees had a "more correct" patch 🙄 I'll take a look at that as well...

@samueldr samueldr mentioned this pull request Feb 14, 2019
Closed
@dtzWill
Copy link
Member Author

dtzWill commented Feb 14, 2019

Looks like we'll be using #55763 or thereabouts, this was only a stop-gap anyway so closing :).

@dtzWill dtzWill closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @grahamc @NeQuissimus @GrahamcOfBorg