Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump webpack-cli dep for lumo #55814

Merged
merged 1 commit into from Feb 18, 2019
Merged

bump webpack-cli dep for lumo #55814

merged 1 commit into from Feb 18, 2019

Conversation

hlolli
Copy link
Member

@hlolli hlolli commented Feb 15, 2019

Motivation for this change

Webpack version 3.2.1 causes a lighercollective error like described here:
webpack/webpack-cli#738

Things done

Bumped webpack-cli and generated the node-10 dependencies, didn't do it for 6 or 8 via the generate.sh file due to a bug I found here #55702

built it and tested lumo

  • [ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hlolli
Copy link
Member Author

hlolli commented Feb 15, 2019

(Regenerating the node-10 deps file due to merge conflict)
EDIT: done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants