New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pantable: init at 0.12.2 #55797
Conversation
d63866c
to
e022a64
Compare
Version meanwhile refreshed up to 12.2. AFAIK good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments only on diff, didn't attempt to build it.
}; | ||
|
||
meta = with lib; { | ||
homepage = https://github.com/mbr/shutilwhich; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote URL
homepage = https://github.com/mbr/shutilwhich; | |
homepage = "https://github.com/mbr/shutilwhich"; |
|
||
meta = with lib; { | ||
homepage = https://github.com/mbr/shutilwhich; | ||
description = "shutil.which for legacy below Python 3.3"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with py27 deprecated, do we want to have new package for py<3.3?
pname = "panflute"; | ||
version = "1.11.2"; | ||
|
||
disabled = ! pythonAtLeast "3.5" && !isPy27; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confusing range, hard to read.
{ lib, buildPythonPackage, pythonAtLeast, isPy27, fetchPypi | ||
, pyyaml, future, click, shutilwhich }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Break onto multiple lines, alphabetize python packages.
|
||
meta = with lib; { | ||
description = "Pythonic pandocfilters with extra helper functions"; | ||
homepage = http://scorreia.com/software/panflute/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
homepage = http://scorreia.com/software/panflute/; | |
homepage = "http://scorreia.com/software/panflute/"; |
{ lib, buildPythonPackage, pythonAtLeast, isPy27, fetchPypi | ||
, panflute, backports_csv }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, line per package
pname = "pantable"; | ||
version = "0.12.2"; | ||
|
||
disabled = ! pythonAtLeast "3.5" && !isPy27; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto on confusing
|
||
meta = with lib; { | ||
description = "CSV Tables in Markdown: Pandoc Filter for CSV Tables"; | ||
homepage = https://ickc.github.io/pantable/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
homepage = https://ickc.github.io/pantable/; | |
homepage = "https://ickc.github.io/pantable/"; |
@@ -4691,7 +4693,7 @@ in | |||
''; | |||
}); | |||
|
|||
pamtester = callPackage ../tools/security/pamtester { }; | |||
pantable = python3Packages.callPackage ../tools/text/pantable { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python packages should usually be in pkgs/top-level/python-packages.nix. Not sure why this package should be at top-level.
Motivation for this change
Useful helper tool for working with pandoc tables + dependencies.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)