Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pandas: don't propagate cython dependency #55745

Merged
merged 1 commit into from Feb 14, 2019
Merged

pythonPackages.pandas: don't propagate cython dependency #55745

merged 1 commit into from Feb 14, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 14, 2019

Motivation for this change

grep'ing pandas derivation output the only possible place where cython can be imported seems to be
https://github.com/pandas-dev/pandas/blob/6a8e7087831193afbc3e1799460614506743077b/pandas/util/_print_versions.py#L68
This is likely not working right now anyway because we are not including some other modules from the list (e.g. fastparquet)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from FRidh as a code owner February 14, 2019 04:13
@7c6f434c 7c6f434c merged commit f6bffa0 into NixOS:master Feb 14, 2019
@FRidh
Copy link
Member

FRidh commented Feb 14, 2019

Note in that case it would be a native build input. I'll fix this on staging.

@7c6f434c
Copy link
Member

7c6f434c commented Feb 14, 2019 •
edited

Oops, right. Noticed the PR doesn't make anything worse ad didn't think about cross-builds (which had the same problem before). Thanks.

@veprbl veprbl deleted the pr/pandas_dont_propagate_cython branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @FRidh @7c6f434c @GrahamcOfBorg