Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazarus: format expression with more modern style #55746

Merged
merged 1 commit into from Feb 14, 2019
Merged

lazarus: format expression with more modern style #55746

merged 1 commit into from Feb 14, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 14, 2019 •
edited

This package was written more than a decade ago; this commit updates the layout
to be more conventional without making any meaningful changes. Note that because
it now has a version attribute in the derivation this does change the hash.

Motivation for this change

Just cleaning up the derivation to make it more familiar/readable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
lazarus: format expression with more modern style
444b26e 
This package was written more than a decade ago; this commit updates the layout
to be more conventional without making any meaningful changes. Note that because
it now has a version attribute in the derivation this does change the hash.
@bhipple
Copy link
Contributor Author

bhipple commented Feb 14, 2019

CC @7c6f434c

@GrahamcOfBorg build lazarus

@7c6f434c 7c6f434c merged commit 0dca6a4 into NixOS:master Feb 14, 2019
@7c6f434c
Copy link
Member

Actually I guess I should also update Lazarus and FPC (it looks like Lazarus 2.0 has been released)

@bhipple bhipple deleted the fix/lazarus branch February 27, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @7c6f434c @GrahamcOfBorg