New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnome3.dconf: fix build on Darwin #55800
Conversation
6794601
to
0deb674
Compare
I rebased and switched the base over to staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If you want to avoid waiting for staging, this could go directly to master if you make it conditional on stdenv.isDarwin
@matthewbauer do we officially support BSD systems? This affects them too AFAIK from the linked issue. Otherwise, I'll gate it to Darwin and switch the base back to master. |
I don't think gating the patch will work in this case. Having |
@hedning Good point! Perhaps I can do an if with attrs merge stdenv.mkDerivation (rec {
} // optionalAttrs stdenv.isDarwin { patches = [ ... ]; }) |
Hehe, there's always a way :) Though I'm not sure if it's really worth it tbh. |
I prefer merging as is to staging obviously. I'll sync up with you on #nixos-dev to see when I can merge it here. |
I don't see any problem with merging to staging, this isn't really a time sensitive patch anyway (polari/freenode is bugging out for me and only lets me connect to #nixos atm). |
We should try to support BSD systems. But not all bsd systems use lld. You could make the condition !stdenv.cc.bintools.isGNU. I’m not sure if it works though.
Anyway this is a temporary fix so what ever you think makes sense is okay. Eventually the fix will be available via dconf update.
…Sent from my iPhone
On Feb 15, 2019, at 4:33 PM, Wael Nasreddine ***@***.***> wrote:
@matthewbauer do we officially support BSD systems? This affects them too AFAIK from the linked issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Motivation for this change
Fix the build on Darwin.
Please see https://gitlab.gnome.org/GNOME/dconf/issues/47
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)