Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z3: Patch file to get rid of python error #55769

Merged
merged 1 commit into from Feb 14, 2019

Conversation

swflint
Copy link
Contributor

@swflint swflint commented Feb 14, 2019

See #55591, Z3Prover/z3#2131

Motivation for this change

Currently, z3 as defined has an issue compiling the python package. Addition of this patch (above PR) fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

That patch is messing with my mind a bit — I spent some time looking for a non-comment/non-string-literal change before reading the PR description.

@GrahamcOfBorg build python36Packages.z3

@swflint
Copy link
Contributor Author

swflint commented Feb 14, 2019

It's crazy, but when Python reads in the file, it chokes on the comment.

@7c6f434c
Copy link
Member

Well, it's not even that crazy a posteriori — it needs to know where comment ends anyway, so it needs to decode every byte including comments. It just happens to have strong opinions on text encoding…

@7c6f434c 7c6f434c merged commit 1ed7dd7 into NixOS:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants