Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package tpm2-tools (+ deps) to nixpkgs #55749

Merged
merged 3 commits into from Feb 19, 2019
Merged

Add package tpm2-tools (+ deps) to nixpkgs #55749

merged 3 commits into from Feb 19, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Feb 14, 2019

Motivation for this change

Nix doesn't have any tools to control TPM 2.0 devices, only TPM 1.2 (tpm-tools / trousers). This PR inits tpm2-tools, Intel's package for TPM 2.0 userland support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

@GrahamcOfBorg build ibm-sw-tpm2 tpm2-tss tpm2-tools

@delroth
Copy link
Contributor Author

delroth commented Feb 19, 2019

I think I fixed ibm-sw-tpm2 on Darwin -- could you re-trigger ofborg?

@ryantm
Copy link
Member

ryantm commented Feb 19, 2019

@GrahamcOfBorg build ibm-sw-tpm2 tpm2-tss tpm2-tools

@delroth
Copy link
Contributor Author

delroth commented Feb 19, 2019

Marked ibm-sw-tpm2 as platforms.linux -- doesn't seem like upstream builds on MacOS properly (and I doubt it will be useful to anyone anyway, other than for running tpm2-tss tests).

The aarch64 failures seemed unrelated to this change though, seems like there's a dependency broken.

@ryantm ryantm merged commit e27fabb into NixOS:master Feb 19, 2019
@ryantm
Copy link
Member

ryantm commented Feb 19, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @ryantm @GrahamcOfBorg