Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifi: 5.9.29 -> 5.10.17 #55727

Merged
merged 1 commit into from Feb 16, 2019
Merged

unifi: 5.9.29 -> 5.10.17 #55727

merged 1 commit into from Feb 16, 2019

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Feb 13, 2019 •
edited

Motivation for this change

Release Notes 5.10.12
Release Notes 5.10.17

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Feb 14, 2019

@0x4A6F 5.10.12 seems to have disappeared:

trying https://dl.ubnt.com/unifi/5.10.12/unifi_sysvinit_all.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found

According to their release notes, there's a 5.10.17 now. Could you update this PR?

@0x4A6F 0x4A6F changed the title unifi: 5.9.29 -> 5.10.12 unifi: 5.9.29 -> 5.10.17 Feb 14, 2019
@flokli
Copy link
Contributor

flokli commented Feb 15, 2019

@0x4A6F please squash together into one commit bumping from 5.9.29 to 5.10.12,, to allow easier backporting. I doubt there will ever be a 5.10.12 anymore ;-)

@flokli flokli merged commit 15f4955 into NixOS:master Feb 16, 2019
@flokli
Copy link
Contributor

flokli commented Feb 16, 2019

backported to 18.09 in 19a0543.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0x4A6F @flokli @bachp @GrahamcOfBorg