Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qjournalctl: init at 2018-11-25 #55762

Closed
wants to merge 1 commit into from
Closed

qjournalctl: init at 2018-11-25 #55762

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 14, 2019

Motivation for this change

qt journalctl frontend :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Apr 9, 2019

@dtzWill I checked out your branch, built it, ran it and everything looking good 👍

@aanderse
Copy link
Member

@dtzWill bump to 0.6 and merge? https://github.com/pentix/qjournalctl

@aanderse
Copy link
Member

aanderse commented Aug 5, 2019

@dtzWill Please consider: aanderse@4e5b3b1

@SRGOM
Copy link
Member

SRGOM commented Jan 20, 2020

@dtzWill Mind if I copy paste this? (I'll assume no if you don't respond in, say, 3 days?)

@SRGOM
Copy link
Member

SRGOM commented Jan 20, 2020 •
edited

Or perhaps @aanderse could kindly merge this so the credit goes where it would and then I would bump

@aanderse
Copy link
Member

@SRGOM feel free to create a PR from your branch that is a fork of this branch. Much appreciated.

@SRGOM
Copy link
Member

SRGOM commented Jan 27, 2020

@aanderse, I don't know much of that git magic (I wrote https://discourse.nixos.org/t/nix-monorepo-size-and-contribution/5565 for my own needs). I can copy paste aanderse@4e5b3b1 at best.

@aanderse
Copy link
Member

@SRGOM just start a fresh PR with a fresh branch. I really recommend you take some time to know git in more depth. It is lovely 😄

@SRGOM SRGOM mentioned this pull request Jan 30, 2020
Closed
10 tasks
@jtojnar
Copy link
Contributor

jtojnar commented Jul 6, 2020

Closing in favour of #78815

@jtojnar jtojnar closed this Jul 6, 2020
@romildo romildo mentioned this pull request Jul 4, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @aanderse @SRGOM @jtojnar @GrahamcOfBorg