Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.conduit-extra: fix darwin sandbox build #55777

Merged
merged 1 commit into from Feb 17, 2019
Merged

haskellPackages.conduit-extra: fix darwin sandbox build #55777

merged 1 commit into from Feb 17, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 14, 2019

The tests depend on localhost networking and get stuck otherwise.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
haskellPackages.conduit-extra: fix darwin sandbox build
34726a8 
The tests depend on localhost networking and get stuck otherwise.
@LnL7 LnL7 merged commit 4c01785 into NixOS:master Feb 17, 2019
@LnL7 LnL7 deleted the haskell-conduit-extra branch February 17, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: haskell 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @GrahamcOfBorg