Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: 1.11.4 -> 1.11.5 #54658

Merged
merged 3 commits into from Jan 27, 2019
Merged

go: 1.11.4 -> 1.11.5 #54658

merged 3 commits into from Jan 27, 2019

Conversation

allowthere
Copy link
Contributor

https://groups.google.com/forum/#!msg/golang-announce/mVeX35iXuSw/Flp8FX7QEAAJ

We have just released Go 1.11.5 and Go 1.10.8 to address a recently reported security issue. We recommend that all users update to one of these releases (if you’re not sure which, choose Go 1.11.5).

This DoS vulnerability in the crypto/elliptic implementations of the P-521 and P-384 elliptic curves may let an attacker craft inputs that consume excessive amounts of CPU.

These inputs might be delivered via TLS handshakes, X.509 certificates, JWT tokens, ECDH shares or ECDSA signatures. In some cases, if an ECDH private key is reused more than once, the attack can also lead to key recovery.

The issue is CVE-2019-6486 and Go issue golang.org/issue/29903. See the Go issue for more details.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@allowthere
go: 1.11.4 -> 1.11.5
d803da8 
https://groups.google.com/forum/#!msg/golang-announce/mVeX35iXuSw/Flp8FX7QEAAJ

We have just released Go 1.11.5 and Go 1.10.8 to address a recently reported security issue. We recommend that all users update to one of these releases (if you’re not sure which, choose Go 1.11.5).

This DoS vulnerability in the crypto/elliptic implementations of the P-521 and P-384 elliptic curves may let an attacker craft inputs that consume excessive amounts of CPU.

These inputs might be delivered via TLS handshakes, X.509 certificates, JWT tokens, ECDH shares or ECDSA signatures. In some cases, if an ECDH private key is reused more than once, the attack can also lead to key recovery.

The issue is CVE-2019-6486 and Go issue golang.org/issue/29903. See the Go issue for more details.
@vcunat
Copy link
Member

vcunat commented Jan 27, 2019 •
edited

  • from the announcement I expect we need to update go_1_10; I'm not sure about _1_9. /cc maintainers missed by Borg: @orivej, @velovix.

It's not a big rebuild, so it seems suitable for direct merge to master. Let's check darwin as well:
@GrahamcOfBorg build go

vcunat
vcunat approved these changes Jan 27, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but I'm not a go person.

@vcunat vcunat mentioned this pull request Jan 27, 2019
Closed
10 tasks
@vcunat
Copy link
Member

vcunat commented Jan 27, 2019

@GrahamcOfBorg build go_1_10

@Mic92
Copy link
Member

Mic92 commented Jan 27, 2019 •
edited

We can merge this as it is. I am just wonder where the eval error is coming from.

@Mic92
Copy link
Member

Mic92 commented Jan 27, 2019

@GrahamcOfBorg eval

@vcunat
Copy link
Member

vcunat commented Jan 27, 2019

That was eval error for master: eb965a4.

@vcunat vcunat mentioned this pull request Jan 27, 2019
Merged
10 tasks
@Mic92 Mic92 merged commit d5f340f into NixOS:master Jan 27, 2019
Mic92 pushed a commit that referenced this pull request Jan 29, 2019
@vcunat @Mic92
go_1_10: 1.10.7 -> 1.10.8 (security)
374f74c 
https://groups.google.com/forum/#!topic/golang-announce/mVeX35iXuSw
#54658
(cherry picked from commit d32e779)
@vcunat vcunat mentioned this pull request Jan 31, 2019
Merged
10 tasks
@allowthere
Copy link
Contributor Author

I updated nixos (nixos-version shows 18.09.2096.2ff7ef373e5), and noticed that go version is still returning go version go1.11.4 linux/amd64.

The reason for this is that which go returns:

 /nix/var/nix/profiles/default/bin/go`, which contains `exec -a "$0" "/nix/store/jjgbr7nwdhp68zl550w6a8jhgx19lx3a-go-1.11.5/share/go/bin/.go-wrapped"  "${extraFlagsArray[@]}" "$@"`

By the name, go-1.11.5 should be go-1.11.5, not 4, but /nix/store/jjgbr7nwdhp68zl550w6a8jhgx19lx3a-go-1.11.5/share/go/bin/go version returns go version go1.11.4 linux/amd64.

The thing is, I do have go 1.11.5. For example, /nix/store/1ph1ncwid9fdksqrz7rp49vgp0lh7623-system-path/bin/go version returns 1.11.5.

Is there something wrong in my patch, or is there something more that needs to be done on the client end?

@vcunat
Copy link
Member

vcunat commented Feb 3, 2019

I'd inspect your which -a go.

$ git checkout 2ff7ef373e5
$ nix build -f . go
$ ls -l ./result
[...] ./result -> /nix/store/rryygxmcqqc9l2vvrl475l3h3zxb1x8c-go-1.11.5
$ ./result/bin/go version
go version go1.11.5 linux/amd64

@allowthere
Copy link
Contributor Author

Yeah, it was a result of a conflict with nix-env. I removed everything from nix-env and everything works now.

Thanks.

@allowthere allowthere deleted the patch-2 branch February 3, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
1.severity: security 6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@allowthere @vcunat @Mic92 @GrahamcOfBorg