Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.11.5 #54657

Closed
wants to merge 1 commit into from
Closed

Update to Go 1.11.5 #54657

wants to merge 1 commit into from

Conversation

allowthere
Copy link
Contributor

@allowthere allowthere commented Jan 27, 2019 •
edited

From https://groups.google.com/forum/#!msg/golang-announce/mVeX35iXuSw/Flp8FX7QEAAJ :

We have just released Go 1.11.5 and Go 1.10.8 to address a recently reported security issue. We recommend that all users update to one of these releases (if you’re not sure which, choose Go 1.11.5).

This DoS vulnerability in the crypto/elliptic implementations of the P-521 and P-384 elliptic curves may let an attacker craft inputs that consume excessive amounts of CPU.

These inputs might be delivered via TLS handshakes, X.509 certificates, JWT tokens, ECDH shares or ECDSA signatures. In some cases, if an ECDH private key is reused more than once, the attack can also lead to key recovery.

The issue is CVE-2019-6486 and Go issue golang.org/issue/29903. See the Go issue for more details.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@allowthere
Update to Go 1.11.5
4bf12e8 
From https://groups.google.com/forum/#!msg/golang-announce/mVeX35iXuSw/Flp8FX7QEAAJ : 

We have just released Go 1.11.5 and Go 1.10.8 to address a recently reported security issue. We recommend that all users update to one of these releases (if you’re not sure which, choose Go 1.11.5).

This DoS vulnerability in the crypto/elliptic implementations of the P-521 and P-384 elliptic curves may let an attacker craft inputs that consume excessive amounts of CPU.

These inputs might be delivered via TLS handshakes, X.509 certificates, JWT tokens, ECDH shares or ECDSA signatures. In some cases, if an ECDH private key is reused more than once, the attack can also lead to key recovery.

The issue is CVE-2019-6486 and Go issue golang.org/issue/29903. See the Go issue for more details.
@vcunat
Copy link
Member

vcunat commented Jan 27, 2019

Let 18.09 wait a couple days for any reactions on #54658

@allowthere
Copy link
Contributor Author

What's the general approach? Merge to master and then cherry-pick to 18.09?

@Mic92
Copy link
Member

Mic92 commented Jan 29, 2019

backported in:

[detached HEAD ef8659b] go: 1.11.4 -> 1.11.5
Author: allowthere 31812983+allowthere@users.noreply.github.com
Date: Sun Jan 27 02:59:44 2019 +0000
1 file changed, 2 insertions(+), 2 deletions(-)
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 2097 and retry the command.
[detached HEAD 374f74c] go_1_10: 1.10.7 -> 1.10.8 (security)
Author: Vladimír Čunát vcunat@gmail.com
Date: Sun Jan 27 11:29:13 2019 +0100
1 file changed, 2 insertions(+), 2 deletions(-)
Press Enter to continue
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 2097 and retry the command.
[detached HEAD 5a3e195] go_1_9: mark as insecure (see the parent commit)
Author: Vladimír Čunát vcunat@gmail.com
Date: Sun Jan 27 11:32:22 2019 +0100
1 file changed, 1 insertion(+)
Press Enter to continue

@Mic92 Mic92 closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@allowthere @vcunat @Mic92 @GrahamcOfBorg @Janik-Haag