Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardnotes: use appimageTools instead of appimage-run #54696

Closed
wants to merge 1 commit into from
Closed

standardnotes: use appimageTools instead of appimage-run #54696

wants to merge 1 commit into from

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Jan 27, 2019 •
edited

Includes #54693

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tilpner tilpner changed the title Standardnotes appimagetools standardnotes: use appimageTools instead of appimage-run Jan 27, 2019
@tilpner
Copy link
Member Author

tilpner commented Jan 27, 2019

cc @M-Gregoire

@M-Gregoire
Copy link
Member

Thank you for this PR, looks good!

@tilpner tilpner mentioned this pull request Feb 1, 2019
Merged
10 tasks
@tilpner tilpner closed this Feb 23, 2019
@tilpner tilpner reopened this Feb 23, 2019
@tilpner tilpner mentioned this pull request Mar 26, 2019
Merged
10 tasks
@tilpner tilpner force-pushed the standardnotes-appimagetools branch from 15240b8 to 60877f5 Compare April 28, 2019 11:50
@dtzWill
Copy link
Member

dtzWill commented Apr 28, 2019 •
edited

Sorry for merging the breakage you pointed out (#56259)! Reverted the breaking commit: 7bd31a3 .

@dtzWill
Copy link
Member

dtzWill commented Apr 28, 2019

Also, FWIW: 98abd18 (upgrade and fix for 32bit platform name).

@dtzWill dtzWill mentioned this pull request Apr 28, 2019
Draft
10 tasks
@tilpner tilpner force-pushed the standardnotes-appimagetools branch from 60877f5 to c873eb2 Compare April 28, 2019 17:34
@tilpner tilpner mentioned this pull request Aug 10, 2019
Merged
@tilpner tilpner closed this Sep 22, 2019
@tilpner tilpner deleted the standardnotes-appimagetools branch September 22, 2019 14:38
@ktor ktor mentioned this pull request Jul 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tilpner @M-Gregoire @dtzWill @GrahamcOfBorg