Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate wrapGAppsHook so that all gnumeric binaries are wrapped,
following the convention used by many gnome applications.
This addresses two issues:
The packaged ssconvert, ssdiff, ssgrep, and ssindex executables
in bin are not currently wrapped so some expected environment
variables including XDG_DATA_DIRS and GIO_EXTRA_MODULES are not
set. The result is many warnings on stderr when running these
commands, e.g.
CRITICAL **:...go_conf_add_monitor: assertion 'node || key' failed
CRITICAL **:...go_conf_get_node: assertion 'parent || key' failed
WARNING **:...unknown GOConfMonitor id.
None of the binaries, including gnumeric, currently wrap the
environment variable GDK_PIXBUF_MODULE_FILE. This can cause
segfaults if an incompatible GDK_PIXBUF_MODULE_FILE is already set
in the environment (e.g. by plasma5). This could be encountered
running a nixos pre-19.03 gnumeric binary from a nixos 18.09 KDE
session.
NOTE 1: This change could potentially impact the darwin package as it
removes an explicit isDarwin check related to GIO_EXTRA_MODULES. The
Darwin case is hopefully handled correctly by conditional code in
wrapGAppsHook. Testing required.
NOTE 2: As with other packages wrapped by wrapGAppsHook, the wrapping
introduces an extra level of wrapping when it encounters a soft link
to an executable in bin. In this package, there is a soft link
from gnumeric to gnumeric-1.12.44. After wrapping with wrapGAppsHook,
the execution flow for gnumeric looks like this:
This may not be optimal, but seems harmless, and could be fixed by
a future update to wrapGAppsHook.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)