Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim-remote: use buildPythonApplication #54717

Merged
merged 1 commit into from Feb 10, 2019
Merged

neovim-remote: use buildPythonApplication #54717

merged 1 commit into from Feb 10, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 27, 2019 •
edited

Motivation for this change

cc @edanaher

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

edanaher
edanaher approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@edanaher edanaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comment in b7e0c40, this looks appropriate to me.

@Mic92 Mic92 merged commit 25bab39 into NixOS:master Feb 10, 2019
@Mic92 Mic92 deleted the nvr branch February 10, 2019 09:03
@iwinux
Copy link
Contributor

iwinux commented Apr 7, 2019

Is it possible to revert it to buildPythonPackage in overlay? I'm using neovim-remote in one of my overlays with python37.withPackages.

@Mic92
Copy link
Member Author

Mic92 commented Apr 8, 2019 •
edited

@iwinux what is your use case? To me at seems that the current approach helps makes it more robust for the majority of users, since nvr is not affected by the environment.

@iwinux
Copy link
Contributor

iwinux commented Apr 10, 2019

@Mic92 use case: a script that communicates with neovim via the nvr module.

My current workaround in overlays:

  neovim-remote-module = python3Packages.buildPythonPackage {
    inherit (neovim-remote) pname version src propagatedBuildInputs meta;
  };

@Mic92
Copy link
Member Author

Mic92 commented Apr 17, 2019

It does not really seems to advertise itself as a library so but a command-line application. This means the API is probably not stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edanaher edanaher edanaher approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @iwinux @edanaher @GrahamcOfBorg