Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions for google cloud platform #259

Merged
merged 6 commits into from Mar 16, 2020
Merged

Conversation

phunehehe
Copy link
Contributor

Mostly copied it from the section about Azure. The make targets are tested but I'm not too sure how to render the document.

@edolstra
Copy link
Member

Thanks, it renders fine. Two comments:

  • 16.03 is pretty old, maybe we can provide a newer version?
  • The download page is not really the best place for extensive installation instructions. Maybe this could be added to the NixOS manual?

@phunehehe
Copy link
Contributor Author

I'm not sure where you see 16.03? In the gce-images.json file generated on my computer latest points to 18.09.
I don't really have an opinion about where this information should be. Currently the NixOS manual only has a passing line mentioning Amazon, whereas the download page has instructions to get NixOS through various ways. That's the only reason I feel it's natural to add GCP there.

@garbas garbas merged commit 0f3ace1 into NixOS:master Mar 16, 2020
@phunehehe phunehehe deleted the gcp branch March 16, 2020 23:55
@phunehehe
Copy link
Contributor Author

@garbas I notice that new GCP images aren't being generated, but thanks for picking this PR up \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants