Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/logind: Add option for HandleLidSwitchExternalPower #55920

Merged
merged 1 commit into from Feb 17, 2019
Merged

nixos/logind: Add option for HandleLidSwitchExternalPower #55920

merged 1 commit into from Feb 17, 2019

Conversation

matix2267
Copy link
Contributor

The default according to man logind.conf is to perform the same action as in
HandleLidSwitch.

Motivation for this change

The other two configuration options (HandleLidSwitch and HandleLidSwitchDocked) are available but this one isn't and currently requires using extraArgs.

This is one of small problems that I encountered on my first installation of NixOS.
I made a full writeup at https://discourse.nixos.org/t/thoughts-from-a-new-nixos-user/2135

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matix2267
nixos/logind: Add option for HandleLidSwitchExternalPower
fb9619c 
The default according to `man logind.conf` is to perform the same action as in
HandleLidSwitch.
@ryantm ryantm merged commit 55fa356 into NixOS:master Feb 17, 2019
@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

thanks!

@matix2267 matix2267 deleted the logind-lid-switch-external-power branch February 17, 2019 09:42
@matix2267 matix2267 restored the logind-lid-switch-external-power branch February 17, 2019 09:42
@matix2267 matix2267 deleted the logind-lid-switch-external-power branch February 17, 2019 09:42
@matix2267 matix2267 mentioned this pull request Feb 18, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matix2267 @ryantm @matthewbauer @GrahamcOfBorg