New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/snapserver: init #55936
nixos/snapserver: init #55936
Conversation
cc @peterhoeg |
I changed the the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final nitpicks
Wait what condition do you mean? How this PR is now, I think it could potentially start mpd/mopidy after snapserver. |
Right now |
Ah yeah, so why not include |
I did that now, because the costs of it are negligible. The strongest argument against is that this list is hard to complete. A better solution would be to specify these config dependent deps outside of the units. But I'm not aware of such a feature in systemd. |
Cool, does systemd handle non-existing units correctly? Well, it should at least not fail the unit is what I hope. |
I just tested the module with mpd installed and no mopidy on the system and it works. So looks like it does. |
Now just squash all commits together and name it "nixos/snapserver: init" and this is good to merge :) |
A nixos module for configuring the server side of pkgs.snapcast. The module is named "snapserver" following upstream convention. This commit does not provide module for the corresponding client. Fix handling of port and controlPort Fix stream uri generation & address review Remove unused streams options & add description Add missing description & Remove default fs path Use types.port for ports & formatting improvements Force mpd and mopidy to wait for snapserver
3feedd5
to
085751b
Compare
Done and done. |
Thanks :) |
A nixos module for configuring the server side of pkgs.snapcast.
The module is named "snapserver" following upstream convention.
This commit does not provide module for the corresponding client.
I've been using this module for a few months.
The module could be simplified to just expose the essential options
and an
extraOptions
to deal with the rest, I'm not sure what theconvention on that is.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)