Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sickgear: 0.17.5 -> 0.18.14 #55939

Merged
merged 1 commit into from Feb 17, 2019
Merged

sickgear: 0.17.5 -> 0.18.14 #55939

merged 1 commit into from Feb 17, 2019

Conversation

rembo10
Copy link
Contributor

@rembo10 rembo10 commented Feb 17, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build sickgear

@ryantm ryantm merged commit 57564a7 into NixOS:master Feb 17, 2019
@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

Thanks; please consider adding yourself to the maintainers.

@worldofpeace
Copy link
Contributor

@rembo10 I think in the future, it would be a good idea to improve the installPhase.

It just drops everything into $out, when things probably should be copied to share/sickgear and then symlink the executable to bin from there.

@rembo10
Copy link
Contributor Author

rembo10 commented Feb 18, 2019

@worldofpeace : sounds good - I can fix it up on the next release

@rembo10 rembo10 deleted the sickgear branch February 18, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rembo10 @worldofpeace @ryantm @GrahamcOfBorg