Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab 11.7.4 -> 11.7.5 #55942

Merged
merged 3 commits into from Feb 19, 2019
Merged

gitlab 11.7.4 -> 11.7.5 #55942

merged 3 commits into from Feb 19, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 17, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from fpletz and globin February 17, 2019 12:47
@flokli
Copy link
Contributor Author

flokli commented Feb 17, 2019

@GrahamcOfBorg build gitlab gitlab-ee nixosTests.gitlab

@fpletz fpletz self-assigned this Feb 19, 2019
@fpletz fpletz merged commit 341f42b into NixOS:master Feb 19, 2019
@fpletz
Copy link
Member

fpletz commented Feb 20, 2019

Backported to 18.09: 28f9452...185ab27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees

@fpletz fpletz

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @fpletz @GrahamcOfBorg