Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.hypothesis 3.79.3 -> 4.5.11 #55897

Closed
wants to merge 1 commit into from
Closed

python.pkgs.hypothesis 3.79.3 -> 4.5.11 #55897

wants to merge 1 commit into from

Conversation

tomecki
Copy link

@tomecki tomecki commented Feb 16, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomecki tomecki requested a review from FRidh as a code owner February 16, 2019 11:39
@srhb
Copy link
Contributor

srhb commented Feb 16, 2019

@GrahamcOfBorg eval

@FRidh FRidh self-assigned this Feb 16, 2019
FRidh
FRidh requested changes Feb 16, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to target staging branch and requires testing using python-unstable jobset.

@tomecki tomecki closed this Feb 16, 2019
@tomecki tomecki changed the base branch from master to staging February 16, 2019 13:24
@tomecki tomecki reopened this Feb 16, 2019
@tomecki
Copy link
Author

tomecki commented Feb 16, 2019

@GrahamcOfBorg eval

@tomecki
Copy link
Author

tomecki commented Feb 16, 2019

@FRidh this looks like a job has failed miserably - what can I do to fix this PR?

@FRidh
Copy link
Member

FRidh commented Feb 16, 2019

@GrahamcOfBorg eval

@tomecki
Copy link
Author

tomecki commented Feb 18, 2019

@FRidh anything else I can do at this point?

@FRidh
Copy link
Member

FRidh commented Feb 18, 2019

no

@srhb
Copy link
Contributor

srhb commented Feb 21, 2019

@GrahamcOfBorg eval

@tomecki
Copy link
Author

tomecki commented Feb 22, 2019

@FRidh good to go?

@FRidh
Copy link
Member

FRidh commented Feb 22, 2019

Checking 068b73e with https://hydra.nixos.org/eval/1506228. There shouldn't be (significant) more failures. If all goes well, we can then merge it directly in staging-next in time for branch-off. Keeping this PR open just for tracking.

@FRidh
Copy link
Member

FRidh commented Feb 23, 2019

There are too many failures to make 4.5 the new default. I will test as well with the latest 3.x.y version and see how that goes. We may have a hypothesis_4 attribute as well considering the relative importance of the package.

@FRidh FRidh mentioned this pull request Mar 2, 2019
Closed
10 tasks
@FRidh
Copy link
Member

FRidh commented Mar 3, 2019

3.88.3 is now in master and staging-19.03. I think in a couple of months we can upgrade to 4.x.

@FRidh FRidh closed this Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tomecki @srhb @FRidh @GrahamcOfBorg @Janik-Haag