Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5.qtconnectivity: fix darwin build #55910

Merged
merged 1 commit into from Feb 20, 2019
Merged

qt5.qtconnectivity: fix darwin build #55910

merged 1 commit into from Feb 20, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 16, 2019 •
edited

Motivation for this change

Fix one of the problems that prevents qt5.full from building #55892

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from ttuegel as a code owner February 16, 2019 17:14
@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde labels Feb 16, 2019
@veprbl veprbl force-pushed the pr/qt5_qtconnectivity_darwin_fix branch from 186da22 to 6e291e5 Compare February 16, 2019 17:24
@ttuegel
Copy link
Member

ttuegel commented Feb 16, 2019

@veprbl It looks like you also need to include cf-private as an input to each Qt package set from all-packages.nix.

@veprbl veprbl force-pushed the pr/qt5_qtconnectivity_darwin_fix branch from 6e291e5 to 4bf4484 Compare February 16, 2019 23:14
@veprbl
Copy link
Member Author

veprbl commented Feb 16, 2019

@ttuegel Yeah, that was the problem, now fixed.

@GrahamcOfBorg build qt56.qtconnectivity
@GrahamcOfBorg build qt59.qtconnectivity
@GrahamcOfBorg build qt511.qtconnectivity

@matthewbauer matthewbauer merged commit 8724819 into NixOS:master Feb 20, 2019
@veprbl veprbl deleted the pr/qt5_qtconnectivity_darwin_fix branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @ttuegel @matthewbauer @GrahamcOfBorg