New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dlang update #55998
Dlang update #55998
Conversation
@GrahamcOfBorg build ldc dmd dtools dub |
d2422e7
to
3ca3a6d
Compare
1632aff
to
f6f3811
Compare
f6f3811
to
6e86798
Compare
Can somebody please check if the current state of this PR works on macOS? |
dmdBuild fails for me: https://gist.github.com/4e91fbbc81327745b36d81d0bce7946d |
@GrahamcOfBorg build ldc dmd dtools dub |
Thanks! |
Btw. what's going on on hydra? All darwin builds fail with "canceled by user". |
10.13 |
All evaluations (even older ones) were stopped just few hours ago I would guess that they were terminated to drop current backlog. I could find a mention of an issue on IRC https://logs.nix.samueldr.com/nixos/2019-02-18#1971702; |
Wow, just wow. I found the commit which introduced the build failure for dmd: ca1062e It's a changed documentation/comment in the make-wrapper. 😵 |
https://forum.dlang.org/post/diycgerwjablujwsfrcs@forum.dlang.org explains a bit the details about what is dmd trying to do. |
@ThomasMader This is certainly a nice find, but do you have an explanation for what is going on? |
Not yet but that commit seems not to be the correct one. |
6e86798
to
c6926c8
Compare
@GrahamcOfBorg build ldc dmd dtools dub |
Ok let's get this into master for now before the branch off. It's important to update the packages to the new versions and all the other changes make everything much more resilient. The dmd problem with the "-run" parameter on macOS is not understood yet but I disabled the failing tests for now to get a working build and this situation is better than what is currently in master.
It happens when dmd is used with the -run parameter which compiles, links and runs the program without leaving any files on the machine. As it is not used as heavily and not needed at all for building other packages it's not a blocker. |
@GrahamcOfBorg build ldc |
I've tried to rebuild this on macOS. This time I get a failure in dtools: https://gist.github.com/veprbl/3e0be30bd86142418232f6bf1ff57147 |
c6926c8
to
2228ac4
Compare
Sorry, forgot to build dtools on macOS. Fixed it by disabling the only test which was using the -run parameter for now. I also changed the names you suggested. |
I think you squashed two dub-related commits so the new commit message "dub: Disable network tests because they add impurities" doesn't mention the version bump. |
No dub stayed at the same version because there is no new version yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds on linux and darwin. dmd -run
is broken on darwin on current master, so no regression here. This PR fixes dmd build on darwin and improves testing, so this is definitely an improvement.
2228ac4
to
0e88d17
Compare
@ThomasMader Thank you! |
Motivation for this change
Bring dlang versions to newest versions and refactor everything to be nicer.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)