Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: add pdo odbc support #55997

Merged
merged 1 commit into from Feb 20, 2019
Merged

php: add pdo odbc support #55997

merged 1 commit into from Feb 20, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

In master nixpkgs has no way to connect to a mssql database anymore. Adding odbc support in php combined with the unixODBCDrivers.msodbcsql17 package will allow a connection to a mssql database in php again.

I still need to test this against a mssql database, which I plan to do tomorrow.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

etu
etu approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍

@aanderse aanderse changed the title WIP: php: add pdo odbc support php: add pdo odbc support Feb 19, 2019
@aanderse
Copy link
Member Author

Confirmed this is working with MSSQL database.
@matthewbauer willing to commit before 19.03 freeze?

@etu etu merged commit 2407f4c into NixOS:master Feb 20, 2019
@etu
Copy link
Contributor

etu commented Feb 20, 2019

@aanderse Thanks :-)

@aanderse aanderse deleted the php-odbc branch February 20, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @matthewbauer @etu @GrahamcOfBorg