Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epkowa: support Epson Perfection V330 Photo #55993

Merged
merged 1 commit into from Feb 20, 2019
Merged

Conversation

bebehei
Copy link
Contributor

@bebehei bebehei commented Feb 18, 2019

Motivation for this change

This adds the iscan plugin for Epson Perfection V330 Photo scanner. It's mostly just copy & paste of another module with some changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is my first PR. I've read CONTRIBUTING.md and I guess it should fit, but I'm not sure about the rest, which is listed in the PR template.

@veprbl
Copy link
Member

veprbl commented Feb 19, 2019

cc @symphorien

@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

@symphorien
Copy link
Member

I can't test, but looks good to me :) Thanks!

@veprbl veprbl merged commit fa82ebc into NixOS:master Feb 20, 2019
@veprbl
Copy link
Member

veprbl commented Feb 20, 2019

@bebehei @symphorien Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants