Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first batch of compatible applications #55988

Merged
merged 1 commit into from Feb 22, 2019
Merged

first batch of compatible applications #55988

merged 1 commit into from Feb 22, 2019

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Feb 18, 2019 •
edited

Motivation for this change

Add more expressions to darwin platform. Basically, simply changing locally the meta.platforms field and trying to recompile. When build succeeds, replace the value by platforms.unix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
Copy link
Contributor Author

Related to #55770

@FRidh
Copy link
Member

FRidh commented Feb 18, 2019

The commit title should say what the commit implements.

@freezeboy
Replace platforms.linux with platforms.darwin for expressions that co…
8f87a61 
…mpile on darwin too (too restrictive platforms)
@vcunat vcunat added the 6.topic: darwin Running or building packages on Darwin label Feb 18, 2019
@freezeboy
Copy link
Contributor Author

Is it better this way ?

Don't know how to fix the grahamcofborg-eval-nixpkgs-unstable-jobset problem

@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

@vcunat
Copy link
Member

vcunat commented Feb 19, 2019

That problem was due to a breakage on master that had been fixed in the meantime.

@freezeboy
Copy link
Contributor Author

I suppose I should still do something, but no idea what

@vcunat
Copy link
Member

vcunat commented Feb 19, 2019

Why? It shows green now, doesn't it?

@freezeboy
Copy link
Contributor Author

well nobody/norobot merges it

@vcunat
Copy link
Member

vcunat commented Feb 22, 2019 •
edited

I'm not a darwin person, but it seems unlikely more people will react to this (like test or something).

@vcunat vcunat merged commit 8f87a61 into NixOS:master Feb 22, 2019
vcunat added a commit that referenced this pull request Feb 22, 2019
@vcunat
Merge #55988: treewide meta.platforms: linux -> unix
4ba49d3
@vcunat
Copy link
Member

vcunat commented Mar 1, 2019

You can review the result.

  • There might be new packages from others mixed in.
  • Some errors are due to transient problems, e.g. stuff depending on the failed go build.

@freezeboy freezeboy deleted the add-darwin-platform branch March 1, 2019 19:41
@freezeboy
Copy link
Contributor Author

Not bad at all, thank you for the link, do you know how to trigger a new attempt ? I tried some of the failed ones and I confirm that it was a temp problem.

@vcunat
Copy link
Member

vcunat commented Mar 1, 2019 •
edited

There have been some large dependency updates, so they should all get rebuilt (within a few days). You can see those on links like https://hydra.nixos.org/job/nixpkgs/trunk/fsql.x86_64-darwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: emacs 6.topic: python 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@freezeboy @FRidh @matthewbauer @vcunat @GrahamcOfBorg @Janik-Haag