Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5.qtwebengine: fail properly #55929

Merged
merged 1 commit into from Feb 19, 2019
Merged

qt5.qtwebengine: fail properly #55929

merged 1 commit into from Feb 19, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 17, 2019 •
edited

Motivation for this change

qtwebengine currently appears to build successfully on darwin, but in reality it fails to configure. The problem is not darwin-specific though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS build fails as expected
    • other Linux distributions, tested qt511.qtwebengine qt512.qtwebengine qt59.qtwebengine build fine
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
qt5.qtwebengine: fail properly
94f098e 
QtWebEngine's build system is setup to perform certain platform checks
(see mkspecs/features/platform.prf). But a failed check will not cause
configuration phase to fail, but instead it configures no build targets.
So in such case the build will successfully perform build and install
phases. An empty output directories will are produced and the build
succeeds.

This patches qtwebengine qmake files to properly fail during
configuration phase.

This doesn't touch qt56 as it doesn't have this mechanism.
@veprbl veprbl requested a review from ttuegel as a code owner February 17, 2019 05:47
@veprbl veprbl merged commit 3e3e391 into NixOS:master Feb 19, 2019
@veprbl veprbl deleted the pr/qtwebengine_fail_properly branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @GrahamcOfBorg