New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thinkfan: 0.9.3 -> 1.0.1 #55895
thinkfan: 0.9.3 -> 1.0.1 #55895
Conversation
@GrahamcOfBorg eval |
src = fetchFromGitHub { | ||
owner = "vmatare"; | ||
repo = "thinkfan"; | ||
rev = "${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rev = "${version}"; | |
rev = version; |
}; | ||
|
||
nativeBuildInputs = [ cmake ]; | ||
configureFlags = [ | ||
"-DCMAKE_INSTALL_DOCDIR==share/doc/${name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two equal signs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryantm I'm still learning and do not know how to do it right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One equal sign is enough. (See e.g. https://linux.die.net/man/1/cmake)
Hi @geekware ! Thanks for your contribution so far. Do you need any specific assistance getting this wrapped up? The suggestions above can be incorporated by amending and force pushing your commit on your branch. :) |
thinkfan: 0.9.3 -> 1.0.2 (replaces #55895)
Motivation for this change
http://thinkfan.sourceforge.net/ is dead since latest release at 2016-05-05!
Repo https://github.com/vmatare/thinkfan is alive with active development.
As say https://github.com/vmatare/thinkfan/blob/master/README#L66 new version have options USE_NVML, USE_ATASMART, USE_YAML. I could not do the right switches. I would be grateful if someone make it more correctly.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)