Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thinkfan: 0.9.3 -> 1.0.1 #55895

Closed
wants to merge 1 commit into from
Closed

Conversation

geekware
Copy link
Contributor

Motivation for this change

http://thinkfan.sourceforge.net/ is dead since latest release at 2016-05-05!
Repo https://github.com/vmatare/thinkfan is alive with active development.

As say https://github.com/vmatare/thinkfan/blob/master/README#L66 new version have options USE_NVML, USE_ATASMART, USE_YAML. I could not do the right switches. I would be grateful if someone make it more correctly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Feb 16, 2019

@GrahamcOfBorg eval

src = fetchFromGitHub {
owner = "vmatare";
repo = "thinkfan";
rev = "${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "${version}";
rev = version;

};

nativeBuildInputs = [ cmake ];
configureFlags = [
"-DCMAKE_INSTALL_DOCDIR==share/doc/${name}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two equal signs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryantm I'm still learning and do not know how to do it right.

Copy link
Member

@pSub pSub Feb 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One equal sign is enough. (See e.g. https://linux.die.net/man/1/cmake)

@srhb
Copy link
Contributor

srhb commented Mar 11, 2019

Hi @geekware ! Thanks for your contribution so far. Do you need any specific assistance getting this wrapped up?

The suggestions above can be incorporated by amending and force pushing your commit on your branch. :)

peterhoeg added a commit that referenced this pull request Sep 30, 2019
thinkfan: 0.9.3 -> 1.0.2 (replaces #55895)
@peterhoeg peterhoeg closed this Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants