Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: 4.7.10 -> 4.7.12 [18.09] #55893

Merged
merged 1 commit into from Feb 24, 2019
Merged

samba: 4.7.10 -> 4.7.12 [18.09] #55893

merged 1 commit into from Feb 24, 2019

Conversation

andrew-d
Copy link
Contributor

Motivation for this change

Security update; see #55392

(cherry-picking #55890 onto 18.09)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @ckauhaus

@vcunat
Copy link
Member

vcunat commented Feb 24, 2019 •
edited

This breaks sambaFull build:

The MIT Kerberos build of Samba as an AD DC is experimental. Therefore --with-system-mitkrb5 requires either --with-experimental-mit-ad-dc or --without-ad-dc

@vcunat
Copy link
Member

vcunat commented Feb 24, 2019

Oh, that's actually closely related to one of the security fixes:

  • CVE-2018-16853 (Samba AD DC S4U2Self crash in experimental MIT Kerberos configuration (unsupported))

@vcunat vcunat mentioned this pull request Feb 24, 2019
Merged
10 tasks
@vcunat
Copy link
Member

vcunat commented Feb 24, 2019

Let's test darwin build as well
@GrahamcOfBorg build samba sambaFull

@vcunat vcunat self-assigned this Feb 24, 2019
@vcunat vcunat merged commit 3a244e8 into NixOS:release-18.09 Feb 24, 2019
vcunat added a commit that referenced this pull request Feb 24, 2019
@vcunat
Merge #55893: samba: 4.7.10 -> 4.7.12
494f3ca 
... into release-18.09.  Contains security fixes.
@andrew-d andrew-d deleted the andrew/samba-4.7.12-1809 branch February 25, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@wkennington wkennington Awaiting requested review from wkennington

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-d @vcunat @GrahamcOfBorg