Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skrooge: remove QtWebKit dependency #55930

Merged
merged 1 commit into from Feb 17, 2019
Merged

skrooge: remove QtWebKit dependency #55930

merged 1 commit into from Feb 17, 2019

Conversation

alapshin
Copy link
Contributor

Motivation for this change

Remove QtWebkit dependency introduced in
a1b8fe8

It is no longer needed after upstream fix
https://cgit.kde.org/skrooge.git/commit/?id=cb8b56fa729d5f6ee4652e79de354721f4742ee7

Corresponding check in #53079 could be updated after this PR is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alapshin
skrooge: remove QtWebKit dependency
7460b95 
Remove QtWebkit dependency introduced in
a1b8fe8

It is no longer needed after upstream fix
https://cgit.kde.org/skrooge.git/commit/?id=cb8b56fa729d5f6ee4652e79de354721f4742ee7
@veprbl veprbl mentioned this pull request Feb 17, 2019
Closed
69 tasks
@veprbl
Copy link
Member

veprbl commented Feb 17, 2019

cc @jokogr
@GrahamcOfBorg build skrooge

veprbl
veprbl approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@veprbl veprbl merged commit b94bdd8 into NixOS:master Feb 17, 2019
@alapshin alapshin deleted the skrooge branch February 17, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@jokogr jokogr Awaiting requested review from jokogr

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alapshin @veprbl @GrahamcOfBorg