Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-nsswitch: add option to configure nssHosts #55843

Merged
merged 1 commit into from Feb 22, 2019
Merged

nixos-nsswitch: add option to configure nssHosts #55843

merged 1 commit into from Feb 22, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 15, 2019

Enables adding or overriding the default nsswitch hosts in a generic
way for packages without a nixos module.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 requested a review from infinisil as a code owner February 15, 2019 18:28
@LnL7
nixos/nsswitch: add option to configure nssHosts
11cd761 
Enables adding or overriding the default nsswitch hosts in a generic
way for packages without a nixos module.
@infinisil infinisil merged commit cc98350 into NixOS:master Feb 22, 2019
@LnL7 LnL7 deleted the nixos-nss-hosts branch February 23, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @infinisil @GrahamcOfBorg