Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-hardkernel: 4.14.87-153 -> 4.14.94-155 #55845

Merged
merged 1 commit into from Feb 19, 2019

Conversation

qolii
Copy link
Contributor

@qolii qolii commented Feb 15, 2019

Motivation for this change

Version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Feb 15, 2019

Note that if this kernel bump includes the patch from https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8099b047ecc431518b9bb6bdbba3549bbecdc343 without having also been reverted, it will break NixOS.

@qolii
Copy link
Contributor Author

qolii commented Feb 15, 2019

@grahamc, is this relevant even to the 4.14 long-term kernel?

I don't know how to check easily if this is there or not.

How obvious is the breakage if it happens? I've been running the built kernel on my hardware for the last week or so, including large rebuilds of the system. Everything seems fine.

@vcunat
Copy link
Member

vcunat commented Feb 15, 2019

The problem was being backported to all branches. You try to apply the patch and either it succeeds or it tells you it can't (and notices that reverse application would work).

@lopsided98
Copy link
Contributor

Neither 4.14.87 nor 4.14.94 need the patch, but it was already mistakenly applied to linux_hardkernel_4_14 in f0b8a11, which means the package is currently broken.

@lopsided98
Copy link
Contributor

See #55861

@qolii
Copy link
Contributor Author

qolii commented Feb 16, 2019

Excellent news (kinda!).

As I said, I've been using this pretty intensively for a week, and observed no issues. If you guys are happy to proceed, I think this is ok to merge (after #55861, presumably)

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interpreter patch on 4.14 is only required for .99 and .100. I'm sorry for the confusion.

@vcunat vcunat merged commit ed76b12 into NixOS:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants