mbed-cli: 1.8.3 -> 1.9.1 #55916
Merged
mbed-cli: 1.8.3 -> 1.9.1 #55916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs #53954 (comment) |
|
I think I got the tests to run doing diff --git a/pkgs/development/tools/mbed-cli/default.nix b/pkgs/development/tools/mbed-cli/default.nix
index 8b96d3a3011..cd80a5ad9e6 100644
--- a/pkgs/development/tools/mbed-cli/default.nix
+++ b/pkgs/development/tools/mbed-cli/default.nix
@@ -1,4 +1,4 @@
-{ lib, python3Packages }:
+{ lib, python3Packages, git, mercurial }:
with python3Packages;
@@ -11,7 +11,18 @@ buildPythonApplication rec {
sha256 = "1228plh55id03qywsw0ai88ypdpbh9iz18jfcyhn21pci7mj77fv";
};
- doCheck = false; # Tests cannot import mbed.
+ checkInputs = [
+ git
+ mercurial
+ pytest
+ ];
+
+ checkPhase = ''
+ export GIT_COMMITTER_NAME=nixbld
+ export EMAIL=nixbld@localhost
+ export GIT_COMMITTER_DATE=$SOURCE_DATE_EPOCH
+ pytest test
+ '';
meta = with lib; {
homepage = https://github.com/ARMmbed/mbed-cli;Had to set identity env vars because it was making the tests fail. |
|
@worldofpeace I commited the change you proposed dd4a1c1 |
|
@GrahamcOfBorg build mbed-cli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)I tried to enable tests, but they fail, saying that
maincannot be imported frommbed.I believe this file is the reason: https://github.com/ARMmbed/mbed-cli/blob/1.9.1/mbed/__main__.py