Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libhandy: 0.0.7 -> 0.0.8 #55980

Merged
merged 1 commit into from Feb 21, 2019
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 18, 2019

https://source.puri.sm/Librem5/libhandy/commit/3721b490b6aacd0a8c755bf445b0a91ee9c347bc

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

  • Add -s -noreset to xvfb-run calls. Xvfb will close when the last client exists, which may be the cause of sporadic test failures. Add -s -noreset to the command line to prevent this from happening

Think we'll have to add -noreset then.

@worldofpeace
Copy link
Contributor

  • Add -s -noreset to xvfb-run calls. Xvfb will close when the last client exists, which may be the cause of sporadic test failures. Add -s -noreset to the command line to prevent this from happening

Think we'll have to add -noreset then.

Actually, I don't think hydra has ever had a problem with the tests.

@worldofpeace worldofpeace merged commit e0baf51 into NixOS:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants