Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.hub: 2.7.0 -> 2.9.0 #55954

Merged
merged 1 commit into from Feb 18, 2019
Merged

gitAndTools.hub: 2.7.0 -> 2.9.0 #55954

merged 1 commit into from Feb 18, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fix #55211

In particular I've fixed the failure to build the man-pages as noted by @Ma27.
We simply needed to add git to path and set the locale.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
gitAndTools.hub: 2.7.0 -> 2.9.0
96ac29b 
We need to add git to PATH to build the manual
as they execute `hub version | tail -1` to get the version
to embed into it.

Though git is really only needed because it runs `git version`
as well.
@ryantm ryantm merged commit 174b938 into NixOS:master Feb 18, 2019
@worldofpeace worldofpeace deleted the bump-hub branch February 18, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @ryantm @GrahamcOfBorg