Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdevelop: added ability to include kdevelop plugins, kdev-php: init at 5.3.1, kdev-python: init at 5.3.1 #55872

Merged
merged 1 commit into from Feb 19, 2019
Merged

kdevelop: added ability to include kdevelop plugins, kdev-php: init at 5.3.1, kdev-python: init at 5.3.1 #55872

merged 1 commit into from Feb 19, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Feb 16, 2019 •
edited

Motivation for this change

Added php and python support as optional plugins for kdevelop.

Note: There is a bug upstream which I have submitted a patch for to fix a problem in kdevelop on nixos. See https://invent.kde.org/kde/kdevelop/merge_requests/8 for details. The issue likely won't be resolved in kdevelop before 19.03 so I suggest this PR is merged as is.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
kdevelop: added ability to include kdevelop plugins
49802ef 
kdev-php: init at 5.3.1
kdev-python: init at 5.3.1
@aanderse aanderse changed the title WIP: kdevelop: added ability to include kdevelop plugins, kdev-php: init at 5.3.1, kdev-python: init at 5.3.1 kdevelop: added ability to include kdevelop plugins, kdev-php: init at 5.3.1, kdev-python: init at 5.3.1 Feb 19, 2019
@aanderse
Copy link
Member Author

@GrahamcOfBorg build kdevelop kdev-php kdev-python

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixos-19-03-feature-freeze/1950/31

@fpletz fpletz merged commit 160abfe into NixOS:master Feb 19, 2019
@aanderse aanderse deleted the kdevelop-php branch February 19, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @nixos-discourse @fpletz