Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguageClient-neovim: 2018-09-07 -> 0.1.140 #55857

Merged
merged 1 commit into from Feb 17, 2019
Merged

LanguageClient-neovim: 2018-09-07 -> 0.1.140 #55857

merged 1 commit into from Feb 17, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Feb 15, 2019

Motivation for this change

Use the latest release instead of a rev.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tobim
Copy link
Contributor Author

tobim commented Feb 15, 2019

There is already another similar PR: https://github.com/NixOS/nixpkgs/pull/54948/files. But that one does not update the version field.
cc @teto

@teto
Copy link
Member

teto commented Feb 16, 2019

ok I deleted mine.

@tobim
Copy link
Contributor Author

tobim commented Feb 16, 2019

I should have looked for an open PR before opening mine. I only discovered yours after this was already done. No harm intended.

@tobim
Copy link
Contributor Author

tobim commented Feb 16, 2019

Not sure who should review this. Maybe @garbas or @Mic92?

@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

@GrahamcOfBorg build LanguageClient-neovim

@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

@GrahamcOfBorg build vimPlugins.LanguageClient-neovim

@ryantm ryantm merged commit 89e0551 into NixOS:master Feb 17, 2019
@teto
Copy link
Member

teto commented Feb 22, 2019

Not sure why but running $ pkgs/misc/vim-plugins/update.py from channels/nixos-unstable (fa82ebc), I get:


error: while evaluating the attribute 'src.rev' at /home/teto/nixpkgs2/pkgs/misc/vim-plugins/overrides.nix:63:5:
attribute 'rev' missing, at (string):8:13
Traceback (most recent call last):
  File "pkgs/misc/vim-plugins/update.py", line 353, in <module>
    main()
  File "pkgs/misc/vim-plugins/update.py", line 334, in main
    current_plugins = get_current_plugins()
  File "pkgs/misc/vim-plugins/update.py", line 144, in get_current_plugins
    out = subprocess.check_output(["nix", "eval", "--json", GET_PLUGINS])
  File "/nix/store/6la3fblc497pacyy0vxhnjq1l1wlb5w7-python3-3.7.2/lib/python3.7/subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "/nix/store/6la3fblc497pacyy0vxhnjq1l1wlb5w7-python3-3.7.2/lib/python3.7/subprocess.py", line 487, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['nix', 'eval', '--json', '(with import <localpkgs> {};\nlet\n  hasChecksum = value: lib.isAttrs value && lib.hasAttrByPath ["src" "outputHash"] value;\n  getChecksum = name: value:\n    if hasChecksum value then {\n      submodules = value.src.fetchSubmodules or false;\n      sha256 = value.src.outputHash;\n      rev = value.src.rev;\n    } else null;\n  checksums = lib.mapAttrs getChecksum vimPlugins;\nin lib.filterAttrs (n: v: v != null) checksums)']' returned non-zero exit status 1

@tobim
Copy link
Contributor Author

tobim commented Feb 22, 2019

I was not aware that the updater script requires all src attrs to contain a rev. I don't think this requirement makes sense for plugins defined in overrides.nix.
It would also help if update.py had a dry-run mode so it's easy to check if it's broken.

@tobim tobim deleted the update-lcn branch February 22, 2019 14:03
@tobim tobim mentioned this pull request Feb 22, 2019
Merged
10 tasks
@tobim
Copy link
Contributor Author

tobim commented Feb 22, 2019

I opened #56191 that fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobim @teto @ryantm @GrahamcOfBorg