Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: fix bash completion #55948

Merged
merged 1 commit into from Feb 18, 2019
Merged

bazel: fix bash completion #55948

merged 1 commit into from Feb 18, 2019

Conversation

CarlosMChica
Copy link
Contributor

@CarlosMChica CarlosMChica commented Feb 17, 2019

Motivation for this change

Fix bazel bash completion

Things done

bazel bash completion is generated running generate_bash_completion.sh. The line that runs that command was missing prepending bazel-complete-header.bash.

Reference: https://github.com/bazelbuild/bazel/blob/d8dde88207b4c739c74f855b2bc693f3233383b5/scripts/BUILD#L17

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
Copy link
Member

Thanks!

@GrahamcOfBorg build bazel.tests

@Profpatsch Profpatsch merged commit 9c40633 into NixOS:master Feb 18, 2019
@CarlosMChica CarlosMChica deleted the fix-bazel branch February 19, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants